Skip to content

feat: update component command to return proper json result @W-19036340 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

feat: update component command to return proper json result @W-19036340 #459

wants to merge 29 commits into from

Conversation

@nrkruk
Copy link
Collaborator

@nrkruk nrkruk commented Jul 18, 2025

What does this PR do?

  • Update component command to use api-version
  • Component command now returns json
  • Passing back json will allow easier integration with VSCode for the near term until we decide on how best to use a shared library across both CLI and VSCode

What issues does this PR fix or reference?

@W-19036340@

@nrkruk nrkruk self-assigned this Jul 18, 2025
@nrkruk nrkruk added the nomerge Do not merge this PR until label is removed by the author. label Jul 18, 2025
@nrkruk nrkruk requested review from a team as code owners July 18, 2025 04:19
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result feat: update component command to use api-version / return proper json result @W-19036340 Jul 18, 2025
@nrkruk nrkruk changed the title feat: update component command to use api-version / return proper json result @W-19036340 feat: update component command to return proper json result @W-19036340 Jul 18, 2025
maliroteh-sf
maliroteh-sf approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@maliroteh-sf maliroteh-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

svc-cli-bot and others added 15 commits July 18, 2025 20:02
@svc-cli-bot
chore(release): 4.4.1-alpha.0 [skip ci]
6a5cd6a
@nrkruk
chore: upgrade LWC dependencies to version 13.0.31
2b081f2
@nrkruk
Merge branch 'main' into nkruk/updatePreviewCommand
b9d163d
@svc-cli-bot
chore(release): 4.4.2-alpha.0 [skip ci]
4c69ff5
@nrkruk
Merge branch 'main' into nkruk/updatePreviewCommand
e0b24ad
@nrkruk
fix: temp package json changes
e7469b3
@nrkruk
fix: lock file
c0a484f
@svc-cli-bot
chore(release): 4.4.13-alpha.0 [skip ci]
4a98801
@nrkruk
feat: update local dev server URL handling for CODE_BUILDER_URI envir…
5c44b5d 
…onment variable
@nrkruk
refactor: change variable declaration for local dev server URL in Lig…
bac4800 
…htningDevComponent
@svc-cli-bot
chore(release): 4.4.13-codebuilder.0 [skip ci]
bb7ba65
@svc-cli-bot
chore(release): 4.4.13-codebuilder.1 [skip ci]
fd83961
@nrkruk
feat: enhance local dev server URL handling for Code Builder environment
3aae43b
@svc-cli-bot
chore(release): 4.4.13-codebuilder.2 [skip ci]
fbeb872
@nrkruk
fix: code builder trusted origins
ec029c1
@nrkruk
Copy link
Collaborator Author

nrkruk commented Oct 12, 2025

Superseded by #524

@nrkruk nrkruk closed this Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliroteh-sf maliroteh-sf maliroteh-sf approved these changes

Assignees

@nrkruk nrkruk

Labels

nomerge Do not merge this PR until label is removed by the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nrkruk @maliroteh-sf @svc-cli-bot