fix: remove deprecated sfdx-core references#562
Merged
Conversation
mshanemc
commented
Apr 2, 2024
| } else { | ||
| stateAggregator.aliases.set(alias, value); | ||
| const results = await Promise.all( | ||
| Object.entries(parsed).map(async ([alias, value]) => { |
Contributor
Author
There was a problem hiding this comment.
because we're setting aliases in parallel you'll see some NUTs change because the alias entries can end up in any order
[also, they're now good tests of the alias cross-save lockfile feature]
mshanemc
commented
Apr 2, 2024
| it('lists multiple results correctly JSON', () => { | ||
| const result = execCmd('alias list --json', { ensureExitCode: 0 }).jsonOutput?.result; | ||
| expect(result).to.deep.equal([ | ||
| expect(result).lengthOf(3); |
Contributor
Author
There was a problem hiding this comment.
these each now assert the total length and that each item is included
mshanemc
commented
Apr 2, 2024
| } | ||
| } | ||
|
|
||
| export const setUnsetErrorHandler = (err: unknown, alias: string, value?: string): AliasResult => { |
Contributor
Author
There was a problem hiding this comment.
DRY, used by both set and unset
shetzel
approved these changes
Apr 2, 2024
Contributor
shetzel
left a comment
shetzel
left a comment
There was a problem hiding this comment.
nit suggestion: rename setUnsetErrorHandler to aliasErrorHandler?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove use of deprecated methods from aliasAccessor
adjust NUTs to allow aliases:list in any order
What issues does this PR fix or reference?
@W-15387805@