fix: handle a corrupt stash.json file #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Nov 8, 2021
Contributor
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
it's a fine solution for a rare problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a JsonParseError is thrown while reading
stash.jsonfor the deploy ID, the error is now caught, the file is renamed to stash.json_corrupted_ and an error message is displayed that shows the parse failure and the location of the renamed stash.json so users can inspect the file, or possibly rebuild a valid file from the corrupt version.What issues does this PR fix or reference?
@W-7837761@
Testing:
In all cases an error should be thrown. In 1 & 3 the stash.json file will be renamed so running the command again will not result in the same behaviour.