fix: deploy output fixes #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
commented
May 3, 2021
| protected async deploy(): Promise<void> { | ||
| this.isAsync = this.getFlag<Duration>('wait').quantity === 0; | ||
| this.isRest = await this.isRestDeploy(); | ||
| this.log(`*** Deploying with ${this.isRest ? 'REST' : 'SOAP'} API ***`); |
Contributor
Author
There was a problem hiding this comment.
Toolbelt was displaying this and I think we need to continue doing that due to all the REST/SOAP issues
shetzel
commented
May 3, 2021
| deploy.onError(() => { | ||
| deploy.onError((error: Error) => { | ||
| this.progressBar.stop(); | ||
| throw error; |
Contributor
Author
There was a problem hiding this comment.
When we listen to SDR deploy events like this we have to handle the errors.
WillieRuemmele
approved these changes
May 3, 2021
Contributor
WillieRuemmele
left a comment
WillieRuemmele
left a comment
There was a problem hiding this comment.
even did some light QA, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes some deploy output bugs.
--jsonwas specified but incorrectly when the progress bar was in use. This was due to ignoring the event handling errors from SDR, so we now throw the error from the event.@W-8903671@