php-fpm reload by default

[giannello]

The usual workflow with php-fpm is to trigger a reload instead of a restart, to gracefully handle for all the processes to terminate before killing and respawning the children.

Should we change the defaults for the php-fpm service to enforce this behavior?

[TaiSHiNet]

It's defaulted on pillar.example line 56. Altho I agree it should be defaulted on a lower level.

[TaiSHiNet]

https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1242376

Be careful as currently, reload will leave non-working childs that need to be killed manually

And CC: @cheuschober just so you're up to speed with this

[cheuschober]

Thanks @TaiSHiNet, we mostly use Ubuntu here, hence why it's set-up the way it is. As noted, L56 of pillar.example does demonstrate a means for changing the default behavior of restart to reload for specific use-cases and that's a regular way of getting around things. Now, I could change that and ask Ubuntu users to do otherwise but it's a bit hairy. Feels like a good candidate for another grains filter-by. I think I owe @TaiSHiNet a few more changes to the formula but have been busy with other tasks. Probably see something near the end of the week.

[cheuschober]

I've made a few changes in the formula but am away from a testing environment right now.

Please test https://github.com/spsoit/php-formula/tree/fixes_unordered_fpm_params and see if it resolves your issues.

[TaiSHiNet]

I commented out the following lines:

 php:
  ng:
    fpm:
      service:
        enabled: True
#        opts:
#          reload: False

pushed a change and it restarted the daemon (instead of reloading it)

[cheuschober]

Which OS are you using? It should be restarting Ubuntu and reloading others.

[TaiSHiNet]

Ubuntu, which means the result (at least for me) was satisfactory

[n-rodriguez]

@myii I think we can close this one

[myii]

Closing this since it is a very old report. Feel free to reopen this if this is still an issue with the latest version of this formula.

@n-rodriguez, thanks for highlighting this.