-
Notifications
You must be signed in to change notification settings - Fork 286
chore(version): increase default version; remove pid dir on clean; update pillar.example #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@noelmcloughlin Testing this in the CI would mean adjusting this section here: postgres-formula/test/salt/pillar/postgres.sls Lines 17 to 22 in 1d34f8c
Then we'll see which platforms can handle the given version number. |
myii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use version: '13' for testing across all platforms.
|
@vutny Are you OK if |
|
@myii thanks for the review - I implemented your suggested changes; version 13 should be fine across all OS. |
vutny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, tests are passing. Thanks!
|
@noelmcloughlin Merged, thanks for the PR. |
|
🎉 This PR is included in version 0.41.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
This PR is minor:
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context