Skip to content

Conversation

@noelmcloughlin
Copy link
Contributor

@noelmcloughlin noelmcloughlin commented Jun 6, 2021

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR is minor:

  • use more modern version as default
  • remove /var/run/postgresql if it exists on clean
  • update pillar.example version and note on CIDR

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin noelmcloughlin requested review from myii and vutny as code owners June 6, 2021 20:33
@myii
Copy link
Contributor

myii commented Jun 6, 2021

@noelmcloughlin Testing this in the CI would mean adjusting this section here:

# Version to install from upstream repository (if upstream_repo: True)
{%- if not (grains.os_family == 'Debian') %}
version: '9.6'
{%- else %}
version: '10'
{%- endif %}

Then we'll see which platforms can handle the given version number.

Copy link
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use version: '13' for testing across all platforms.

@myii
Copy link
Contributor

myii commented Jun 7, 2021

@vutny Are you OK if version: 13 is used throughout?

@noelmcloughlin
Copy link
Contributor Author

@myii thanks for the review - I implemented your suggested changes; version 13 should be fine across all OS.

Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, tests are passing. Thanks!

@myii myii merged commit 288bea8 into saltstack-formulas:master Jun 14, 2021
@myii
Copy link
Contributor

myii commented Jun 14, 2021

@noelmcloughlin Merged, thanks for the PR.
Appreciate the review, @vutny.

@saltstack-formulas-travis

🎉 This PR is included in version 0.41.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants