Skip to content

[master] Add Virtuozzo Linux as os_family=Redhat#65600

Merged
dwoz merged 6 commits into
saltstack:masterfrom
jealouscloud:virtuozzo-os-family
Jan 19, 2024
Merged

[master] Add Virtuozzo Linux as os_family=Redhat#65600
dwoz merged 6 commits into
saltstack:masterfrom
jealouscloud:virtuozzo-os-family

Conversation

@jealouscloud
Copy link
Copy Markdown
Contributor

@jealouscloud jealouscloud commented Nov 22, 2023

Virtuozzo is a Redhat family OS.

What does this PR do?

Add support for Virtuozzo Linux in OS family map

Previous Behavior

# salt-call grains.get os_family
local:
    Virtuozzo

Failing to detect os_family correctly causes problems in some states. We noticed this in pkgrepo.managed.

New Behavior

# salt-call grains.get os_family
local:
    RedHat

Merge requirements satisfied?

Commits signed with GPG?

Yes

@jealouscloud jealouscloud requested a review from a team as a code owner November 22, 2023 16:47
@jealouscloud jealouscloud requested review from twangboy and removed request for a team November 22, 2023 16:47
@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 22, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title Add Virtuozzo Linux as os_family=Redhat [master] Add Virtuozzo Linux as os_family=Redhat Nov 22, 2023
@jealouscloud jealouscloud mentioned this pull request Nov 22, 2023
2 tasks
Copy link
Copy Markdown
Contributor

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry, changelog/65600.added.md ?

@jealouscloud
Copy link
Copy Markdown
Contributor Author

Can you please add a changelog entry, changelog/65600.added.md ?

Renamed changelog/65600.fixed.md -> changelog/65600.added.md

Comment thread tests/pytests/unit/grains/test_core.py Outdated
s0undt3ch
s0undt3ch previously approved these changes Jan 9, 2024
@twangboy
Copy link
Copy Markdown
Contributor

Looks like you got some failing pre-commit/lint tests. You need to have 2, and only 2, spaces between functions in the test. In one spot you have 1 and in another you have 3. That should fix the pre-commit/lint failures.

@jealouscloud
Copy link
Copy Markdown
Contributor Author

Looks like you got some failing pre-commit/lint tests. You need to have 2, and only 2, spaces between functions in the test. In one spot you have 1 and in another you have 3. That should fix the pre-commit/lint failures.

Was having trouble getting pre-commit setup locally, thank you. I applied the suggested fixes.

twangboy
twangboy previously approved these changes Jan 18, 2024
@twangboy twangboy self-assigned this Jan 18, 2024
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 19, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants