[master] Use --cachedir parameter for setting extension_modules with salt-call#66742
Merged
dwoz merged 3 commits intoSep 19, 2024
Merged
Conversation
salt-project-bot-prod-environment
Bot
changed the title
3 tasks
vzhestkov
force-pushed
the
use-cachedir-cli-for-extension_modules
branch
from
205decf to
9ae5bca
Compare
dmurphy18
previously requested changes
Sep 9, 2024
Contributor
dmurphy18
left a comment
dmurphy18
left a comment
There was a problem hiding this comment.
Needs a changelog entry before it can be reviewed
twangboy
approved these changes
Sep 17, 2024
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
* Use --cachedir parameter for extension_modules with salt-call * Add test to check extension_modules value alignment BACKPORT-UPSTREAM=saltstack#66742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Even if
--cachedircomman line parameter with the new cache target specified forsalt-callthe extension modules are placed tocachedir+/extmodsin most cases with the Salt Bundle it's/var/cache/venv-salt-minion/extmodsor/var/cache/salt/minion/extmodsfor the classic salt-minion.This PR if making the
extension_modulesopts to be aligned withcachedirif specified as CLI parameter forsalt-call.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/24523
Previous Behavior
Keep using original
cachedirdestination value from the config for extension mudules cache even if different destination of cache directory specified with--cachedircomman line parameter.New Behavior
Aligns
extension_modulesin the opts according to the value specified with--cachedircomman line parameter.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.