fix(mac_brew_pkg): manage unknown versions#68763
Merged
dwoz merged 3 commits intosaltstack:3006.xfrom Mar 3, 2026
Merged
Conversation
bdrx312
reviewed
Feb 24, 2026
twangboy
requested changes
Feb 24, 2026
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Since this bug exists in 3006.x, could you please rebase this PR on 3006.x branch?
cdalvaro
force-pushed
the
bugfix/mac_brew_pkg/manage_unknown_versions
branch
from
fcabd30 to
2e426a4
Compare
cdalvaro
force-pushed
the
bugfix/mac_brew_pkg/manage_unknown_versions
branch
from
2e426a4 to
da0c6f1
Compare
twangboy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
mac_brew_pkg.list_pkgscrashing or producing incorrect results when Homebrew returnsnullvalues for cask metadata:null(e.g. Homebrew cannot determine the installed version), it is now reported as"unknown"instead of raising an error.full_tokenisnull, it is now filtered out so thatNoneis never used as a package name key in the returned dictionary.What issues does this PR fix or reference?
This PR manage those situations to avoid propagating
Nonevalues.Merge requirements satisfied?
Commits signed with GPG?
Yes