Skip to content

Skip is_writeable check for log files in /dev/ #62263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcnewton wants to merge 1 commit into from
Closed

Skip is_writeable check for log files in /dev/ #62263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion salt/utils/parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,8 @@ def __setup_logfile_logger_config(self, *args): # pylint: disable=unused-argume
)
)

if not is_writeable(logfile, check_parent=True):
if (not logfile.startswith("file:///dev/") and
not is_writeable(logfile, check_parent=True)):
# Since we're not be able to write to the log file or its parent
# directory (if the log file does not exit), are we the same user
# as the one defined in the configuration file?
Expand Down