samba-container check winbind fails when _GLOBAL_DEBUG is set

[eivindlm]

When _GLOBAL_DEBUG is set to 10, samba-container check winbind attempts to exec wbinfo -p --debuglevel=10, which fails with "Invalid option". This will cause the livenessProbe to fail, effectively killing the container every 30 seconds.

[phlogistonjohn]

Thank you very much for the report!

[anoopcs9]

wbinfo --ping --debuglevel=10 currently doesn't error out which seems to be a bug in the wbinfo tool itself whereas wbinfo --debuglevel=10 --ping is invalid. Luckily samba-container check winbind puts --debuglevel towards the end and thus it works(where it is not supposed to).

@eivindlm Can you please re-confirm whether wbinfo --ping --debuglevel=10 displays "Invalid option" for you or not inside the container? If yes, can you paste the samba container image name and tag used?

[eivindlm]

My wbinfo -p still exits with nonzero return if additional arguments (such as --debuglevel=10) are provided.

[me@my-host ~]$ kubectl -n samba-shares exec -it my-pod-0 -c wb -- /bin/bash
[root@my-pod-0 /]# wbinfo --version
Version 4.20.5
[root@my-pod-0 /]# wbinfo --ping
Ping to winbindd succeeded
[root@my-pod-0 /]# echo $?
0
[root@my-pod-0 /]# wbinfo --ping --debuglevel=10
Ping to winbindd succeeded
Invalid option
Usage: [OPTION...]
[ ..... several lines of output omitted .....]
[root@my-pod-0 /]# echo $?
1

Version information:

[me@my-host ~]$ kubectl -n samba-shares describe po my-pod-0
[...]
Containers:
[...]
  samba:
    Container ID:  containerd://0b045a93dfdcb6e21d4ae35fefbff33e396871139181513c897f53aca23ef493
    Image:         quay.io/samba.org/samba-server:v0.6
    Image ID:      quay.io/samba.org/samba-server@sha256:bdd107cafef6e44bccbdcbf745e30796e7fb5117f24a3ad0a8d5a945e9dd2cbc
[...]

[anoopcs9]

My wbinfo -p still exits with nonzero return if additional arguments (such as --debuglevel=10) are provided.

[me@my-host ~]$ kubectl -n samba-shares exec -it my-pod-0 -c wb -- /bin/bash
[root@my-pod-0 /]# wbinfo --version
Version 4.20.5
[root@my-pod-0 /]# wbinfo --ping
Ping to winbindd succeeded
[root@my-pod-0 /]# echo $?
0
[root@my-pod-0 /]# wbinfo --ping --debuglevel=10
Ping to winbindd succeeded
Invalid option
Usage: [OPTION...]
[ ..... several lines of output omitted .....]
[root@my-pod-0 /]# echo $?
1

Thanks, it is interesting to see that the message indicating a successful ping is also displayed at the top before "Invalid option".

Nevertheless, I think it is wise to not execute the underlying wbinfo command with --debuglevel optional argument. I'll create a fix.