Merged
Conversation
Owner
|
Thanks for the PR! |
|
I loaded version 1.5.3 last night (after enabling MFA in the app) and my commands are working once again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent change on GM's side disabled the existing auth flow. After @joelvandal determined the upgrade was no longer being called I tried defaulting
upgradeRequiredto false and my library, onstar2mqtt, was able to make a diagnostic request.Should fix #214. The functional test gives me a 403 on cancelAlert, however that may be due to my OnStar remote commands plan expiring.