Skip to content

Conversation

@bbean23
Copy link
Collaborator

@bbean23 bbean23 commented Nov 6, 2025

Purpose

Various fixes and improvements to spot analysis.

Fixes #297

Summary of changes

  • Fix rename_file() when working across file systems
  • Fix CroppingImageProcessor.validate_center()
  • Fix CroppingImageProcessor, generally
  • Use better naming convention for annotations meters_per_pixel
  • Fix isinstance and issubclass for OpenCSP LazyLoader
  • Add translate() method to annotations, fix CroppingImageProcessor to automatically translate annotations

Implementation notes

Correctness was verified with unit tests.

Submission checklist

  • Target branch is develop, not main
  • Existing tests are updated or new tests were added
  • opencsp/test/test_DocStringsExist.py are verified to include this change or have been updeted accordingly
  • .rst file(s) under doc/ are verified to include this change or have been updated accordingly

Additional information

No additional information.

@bbean23 bbean23 requested review from e10harvey and jehsharp November 6, 2025 17:57
@bbean23 bbean23 self-assigned this Nov 6, 2025
@bbean23 bbean23 added bug Something isn't working enhancement New feature or request labels Nov 6, 2025
@bbean23 bbean23 linked an issue Nov 6, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@jehsharp jehsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes / additions look good to me, tests were added and all 4 checks passed.

@jehsharp jehsharp merged commit af1d581 into sandialabs:develop Nov 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code Bug]: bugs in spot analysis examples

2 participants