-
Notifications
You must be signed in to change notification settings - Fork 5
feat(health): add /api/health endpoint for monitoring and load balancers #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| """Health check routes for service monitoring and load balancing. | ||
|
|
||
| Provides simple health check endpoint for monitoring tools, orchestrators, | ||
| and load balancers to verify service availability. | ||
| """ | ||
|
|
||
| import logging | ||
| from datetime import datetime, timezone | ||
| from typing import Dict, Any | ||
|
|
||
| from fastapi import APIRouter | ||
|
|
||
| from version import VERSION | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| router = APIRouter(prefix="/api", tags=["health"]) | ||
|
|
||
|
|
||
| @router.get("/health") | ||
| async def health_check() -> Dict[str, Any]: | ||
| """Health check endpoint for service monitoring. | ||
|
|
||
| Returns basic service status information. This endpoint does not require | ||
| authentication and is intended for use by load balancers, monitoring | ||
| systems, and orchestration platforms. | ||
|
|
||
| Returns: | ||
| Dictionary containing: | ||
| - status: Service health status ("healthy") | ||
| - service: Service name | ||
| - version: Service version | ||
| - timestamp: Current UTC timestamp in ISO-8601 format | ||
| """ | ||
| return { | ||
| "status": "healthy", | ||
| "service": "atlas-ui-3-backend", | ||
| "version": VERSION, | ||
| "timestamp": datetime.now(timezone.utc).isoformat() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Unit tests for health check endpoint.""" | ||
|
|
||
| from starlette.testclient import TestClient | ||
| from datetime import datetime | ||
|
|
||
| from main import app | ||
|
|
||
|
|
||
| def test_health_endpoint_returns_200(): | ||
| """Test that health endpoint returns 200 status.""" | ||
| client = TestClient(app) | ||
| resp = client.get("/api/health") | ||
| assert resp.status_code == 200 | ||
|
|
||
|
|
||
| def test_health_endpoint_no_auth_required(): | ||
| """Test that health endpoint works without authentication.""" | ||
| client = TestClient(app) | ||
| # No X-User-Email header provided | ||
| resp = client.get("/api/health") | ||
| assert resp.status_code == 200 | ||
|
|
||
|
|
||
| def test_health_endpoint_response_structure(): | ||
| """Test that health endpoint returns correct response structure.""" | ||
| client = TestClient(app) | ||
| resp = client.get("/api/health") | ||
| assert resp.status_code == 200 | ||
|
|
||
| data = resp.json() | ||
|
|
||
| # Verify all required fields are present | ||
| assert "status" in data | ||
| assert "service" in data | ||
| assert "version" in data | ||
| assert "timestamp" in data | ||
|
|
||
| # Verify field values | ||
| assert data["status"] == "healthy" | ||
| assert data["service"] == "atlas-ui-3-backend" | ||
|
|
||
| # This version number can change, so just check it's a non-empty string | ||
| assert isinstance(data["version"], str) and len(data["version"]) > 0 | ||
|
|
||
| # Verify timestamp is valid ISO-8601 format | ||
| try: | ||
| datetime.fromisoformat(data["timestamp"]) | ||
| except ValueError: | ||
| assert False, f"Invalid timestamp format: {data['timestamp']}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| """Application version constant. | ||
|
|
||
| Single source of truth for the application version number. | ||
| """ | ||
|
|
||
| VERSION = "0.1.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This documentation paragraph is quite long and dense (581 characters in a single paragraph). Consider breaking it into multiple paragraphs or a bulleted list for better readability. For example: