Skip to content

Conversation

@mitchnegus
Copy link
Member

Pull Request Title

Description

The firewheel config set -s ... command does not properly handle whitespace. It takes arguments from the command line and splits them using whitespace (ignoring CLI indicators like quoted parameters). Instead of using the str.split method, the ConfigureFirewheel object (and the underlying Config object) should use shlex.split.

Related Issue

See related discussion on #166.

Type of Change

Please select the type of change your pull request introduces:

  • Bugfix
  • New feature
  • Documentation update
  • Other (please describe):

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • N/A I have commented my code, particularly in hard-to-understand areas.
  • N/A I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

@github-actions github-actions bot added the fix Something isn't working label Oct 15, 2025
@mitchnegus mitchnegus changed the title Fix config set fix: Fix config set Oct 15, 2025
Copy link
Collaborator

@sdelliot sdelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdelliot sdelliot merged commit a05399c into sandialabs:main Nov 6, 2025
15 checks passed
@mitchnegus mitchnegus deleted the fix-config-set branch November 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants