Skip to content

Shared Memory Bug #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge bugfix into develop (resolve failed auto-merge)
merged 1 commit into from
Oct 6, 2025
Merged

Shared Memory Bug #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pygsti/objectivefns/objectivefns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4374,12 +4374,15 @@ def terms(self, paramvec=None, oob_check=False, profiler_str="TERMS OBJECTIVE"):
self.model.from_vector(paramvec)
terms = self.obj.view()

# Whether this rank is the "leader" of all the processors accessing the same shared self.jac and self.probs mem.
# Only leader processors should modify the contents of the shared memory, so we only apply operations *once*
# `unit_ralloc` is the group of all the procs targeting same destination into self.obj
unit_ralloc = self.layout.resource_alloc('atom-processing')
shared_mem_leader = unit_ralloc.is_host_leader

with self.resource_alloc.temporarily_track_memory(self.nelements): # 'e' (terms)
self.model.sim.bulk_fill_probs(self.probs, self.layout)
self._clip_probs()
self.model.sim.bulk_fill_probs(self.probs, self.layout) # syncs shared mem
self._clip_probs() # clips self.probs in place w/shared mem sync

if oob_check: # Only used for termgap cases
if not self.model.sim.bulk_test_if_paths_are_sufficient(self.layout, self.probs, verbosity=1):
Expand Down Expand Up @@ -4412,11 +4415,15 @@ def lsvec(self, paramvec=None, oob_check=False, raw_objfn_lsvec_signs=True):
in {bad_locs}.
"""
raise RuntimeError(msg)
lsvec **= 0.5
unit_ralloc = self.layout.resource_alloc('atom-processing')
shared_mem_leader = unit_ralloc.is_host_leader
if shared_mem_leader:
lsvec **= 0.5
if raw_objfn_lsvec_signs:
if self.layout.resource_alloc('atom-processing').is_host_leader:
if shared_mem_leader:
raw_lsvec = self.raw_objfn.lsvec(self.probs, self.counts, self.total_counts, self.freqs)
lsvec[:self.nelements][raw_lsvec < 0] *= -1
unit_ralloc.host_comm_barrier()
return lsvec

def dterms(self, paramvec=None):
Expand Down