Hack to handle writingto C order and bringing back to F #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
I prefer this to_memory order approach since it is backwards compatible with MATLAB. It also allows us to update the header at somepoint in the future to mark Fortran or C order since the MATLAB currently splits the first line to extract the tensor type. We could update the logic there to error out if necessary to avoid confusion.
An alternative is to look if there is a simple approach to add a performant parse of the file in fortran order but unless we have dramatic performance needs that seems like a lot of work for minimal benefit.
📚 Documentation preview 📚: https://pyttb--464.org.readthedocs.build/en/464/