Add soname to shared library #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
insertinterestingnamehere
left a comment
insertinterestingnamehere
left a comment
There was a problem hiding this comment.
Sure, shared object versioning is generally a good idea. We're in the process of deciding on some deprecations, but we're not planning to do anything that breaks things downstream for chapel so introducing this now is probably fine even if our ABI isn't really fully settled yet.
Aside from the minor redundancy this looks fine.
src/CMakeLists.txt
Outdated
| PROPERTIES C_VISIBILITY_PRESET hidden | ||
| VERSION ${PROJECT_VERSION} | ||
| SOVERSION ${PROJECT_VERSION_MAJOR}) | ||
| target_link_libraries(qthread PUBLIC Threads::Threads) |
Collaborator
There was a problem hiding this comment.
This line is redundant
Collaborator
|
Looks good. The pending CI builds are just because of backed up queues. Merging. Thank you! |
insertinterestingnamehere
merged commit 669b76e
into
sandialabs:main
278 of 288 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369