Fix args for corner #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
this depends on my pep8 change. |
Member
|
Yeah, just getting caught-up this morning. The one issue I have with accepting this as-is is that it includes all of the changes from the autopep8 pull request that I just merged. I don't want to apply those changes twice. I think what you want to do is rebase your changes to master, and resubmit the pull request. As a best practice I want to get to a place where every pull request addresses one well-defined feature or problem. Cheers, |
Author
|
i've removed autopep8 from this patch |
Member
|
Merged, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.