fix(debug): fixes issue with debug showing incorrect info

[binoy14]

Fixes the debug command to match the current CLI. There is some history and subtle difference in the me endpoint when using on the project domain vs global. The global user ID does not match the project role member id so we are using the projects domain whenever possible.

[claude]

Claude finished @binoy14's task —— View job

---

Code Review Complete

• Read repository guidelines (CLAUDE.md)
• Analyze changed files for issues
• Review test coverage and quality
• Provide actionable feedback

Issues Found

Missing Error Handling for API Failures

The gatherProjectInfo function on line 127 in gatherDebugInfo.ts uses unsafe member access that could throw if the API response has unexpected structure:

const member = (projectInfo.members || []).find((member) => member.id === userId)

Fix: Add null check for member.id before comparison since members might have incomplete data.

Type Safety Issue

Line 132 in gatherDebugInfo.ts has a @ts-expect-error comment that suppresses legitimate type errors:

// @ts-expect-error - Incorrect type definition in @sanity/client
userRoles: member && member.roles ? member.roles.map((role) => role.name) : ['<none>'],

Fix: Either update the @sanity/client types or add proper type guards instead of suppressing errors.

Inconsistent Return Types

The gatherUserInfo function returns Error | UserInfo | null but the logic flow can be confusing. Line 91-93 uses a conditional that could be clearer about when project vs global user lookup occurs.
Fix: Add inline comment explaining the conditional logic for project vs global user lookup.

Test Coverage Gap

The test file doesn't cover the edge case where getProjectUser fails but getCliUser would succeed as a fallback. This could mask issues with the project user endpoint.
Fix: Add test case covering project user API failure with global user fallback.

Minor Issues

Performance: Multiple sequential API calls could be parallelized better in gatherDebugInfo.ts:26-28, though this is a minor optimization.

Code Style: The user service function getProjectUser on line 34 in user.ts lacks JSDoc description of its return type behavior compared to getCliUser.

All major functionality changes look correct and the fix addresses the stated issue with global vs project domain user ID differences.

[binoy14]

• fix(debug): fixes issue with debug showing incorrect info #253 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	76.65%	5370 / 7005
🔵	Statements	75.8%	5502 / 7258
🔵	Functions	67.2%	795 / 1183
🔵	Branches	63.78%	2376 / 3725

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/@sanity/cli/src/actions/debug/gatherDebugInfo.ts	92.3%	83.33%	100%	92.1%	65, 73, 116
packages/@sanity/cli/src/commands/debug.ts	100%	87.5%	100%	100%
packages/@sanity/cli/src/services/user.ts	100%	100%	100%	100%

Generated in workflow #1415 for commit faedaa2 by the Vitest Coverage Report Action