fix(core): add typegen to CLI config type

[binoy14]

No description provided.

[binoy14]

• refactor: move test helpers to test package for #230
• fix(core): add typegen to CLI config type #283 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @binoy14's task in 1m 34s —— View job

---

Code Review

• Read changed files
• Analyze implementation
• Post review findings

Issues Found

1. Type mismatch between schema and type definition

The schema (schemas.ts:78) uses z.custom<TypeGenConfig>() while the type definition (cliConfig.ts:89) uses Partial<TypeGenConfig>. These should match.

Fix: Change the schema to match the type definition:

typegen: z.custom<Partial<TypeGenConfig>>().optional(),

2. Version inconsistency

@sanity/codegen is added as ^5.2.0 in cli-core, but original-cli uses ^5.1.0 (see packages/@sanity/original-cli/package.json:85).

Recommendation: Align the versions across packages for consistency, unless there's a specific reason for the version bump.

3. Missing test coverage

No tests were added for the new typegen configuration option.

Recommendation: Add tests to verify the typegen config is properly validated and typed.

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	77.12%	5489 / 7117
🔵	Statements	76.33%	5631 / 7377
🔵	Functions	68.33%	818 / 1197
🔵	Branches	64.17%	2442 / 3805

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/@sanity/cli-core/src/config/cli/schemas.ts	100%	100%	100%	100%

Generated in workflow #1464 for commit f6d2632 by the Vitest Coverage Report Action

[github-actions]

Preview this PR with pkg.pr.new

Run the Sanity CLI

npx https://pkg.pr.new/sanity-io/cli/@sanity/cli@f6d2632 <command>

...Or upgrade project dependencies

📦 @sanity/cli

pnpm install https://pkg.pr.new/@sanity/cli@f6d2632

📦 @sanity/cli-core

pnpm install https://pkg.pr.new/@sanity/cli-core@f6d2632

📦 @sanity/cli-test

pnpm install https://pkg.pr.new/@sanity/cli-test@f6d2632

📦 @sanity/eslint-config-cli

pnpm install https://pkg.pr.new/@sanity/eslint-config-cli@f6d2632

View Commit (f6d2632)