Conversation
Two issues fixed: 1. buildApp was missing the warnAboutMissingAppId call that buildStudio had when auto-updates are enabled but no appId is configured. 2. Both buildStudio and buildApp now skip the warning when called from deploy, since deploy handles appId itself (prompts the user to select/create an app and tells them to add it to config). Added calledFromDeploy option to BuildOptions, set by deployStudio and deployApp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that: - buildStudio/buildApp warn about missing appId when auto-updates enabled - Warning is suppressed when calledFromDeploy is true - Warning is suppressed when appId is configured Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SDK-970 `warnAboutMissingAppId` fixes
9.
|
|
Claude finished @bjoerge's task in 2m 24s —— View job Review
The implementation is correct and the approach makes sense. One minor observation:
Test consistency note ( The Everything else looks good: the |
appId warning to app build
… coverage Remove the redundant warnAboutMissingAppId call in deployApp (the "Next step" block already handles this), matching deployStudio's approach. Add test cases for autoUpdatesEnabled: false in both buildApp and buildStudio appId warning tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…warning test mockReturnValue persists across tests since clearAllMocks only resets call tracking, not implementations. This caused the "appId configured" test to pass for the wrong reason (auto-updates still disabled from the previous test). Use mockReturnValueOnce so the override reverts after a single call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… test Add comment explaining that buildStudio calls shouldAutoUpdate() internally and ignores the autoUpdatesEnabled option, so the mockReturnValueOnce on shouldAutoUpdate is what actually controls the behavior in this test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Description
Two issues fixed:
buildAppwas missing thewarnAboutMissingAppIdcall that buildStudio had when auto-updates are enabled but no appId is configured.Both
buildStudioandbuildAppnow skip the warning when called fromdeploy, since deploy handles
appIditself (prompts the user to select/create an app and tells them to add it to config).Added
calledFromDeployoption to BuildOptions, set bydeployStudioanddeployAppso it can be ignored when build is invoked from deploy.What to review
Makes sense?
Testing
Tests included