fix(auth): do not clear the entire hash during login, only a token value #648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the
getCleanedUrlfunction to preserve hash fragments while only removing the token and withSid parameter. Previously, the function would remove the entire hash, but now it selectively removes only the token and withSid parameters while keeping other hash parameters intact. This provides a better user experience by maintaining URL state after authentication.What to review
getCleanedUrlinutils.tswhich now preserves hash fragmentsTesting
Added comprehensive test cases that cover various URL scenarios:
Fun gif