sap_hypervisor_node_preconfigure: Updated redhat_ocpv #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
August 5, 2025 12:52
- sap_hypervisor_node_preconfigure(redhat_ocpv)
- Added assert for kubeconfig
- Unified storageclass to sapstorage for both trident and hpp and
make configurable
- trident: make parameters configurable in role
- removed unused create-sap-bridge.yml, label-worker-invtsc.yml, sriov-enabled-unsupported-nics.sh
- restructured tasks
- added flags for finegranular tasks control, mainly for debugging
- add vlan interface support
- nmstate: wait for webhooks pods to be available
- fix bridge and NAD name for additional bridges
- added MCP wait to when installing hostpath provisioner
- Storageclass names and default is configurable now
- Wait and check for hco-webhook pod
- hostpath provisioner: mkfs.xfs in pod, simplified systemd
startup scripts
…cpv_subscription_channel
… it renders to 'True' wheras it has to be set to 'true'
Contributor
|
@newkit @geetikakay Since you are doing it now, make sure to test it against new |
Member
Author
|
@marcelmamula I would like to ensure |
Contributor
|
@newkit Last PR was stopped by @geetikakay so I will wait for approval first, before giving mine. |
Collaborator
|
/lgtm |
marcelmamula
approved these changes
Aug 5, 2025
Contributor
marcelmamula
left a comment
marcelmamula
left a comment
There was a problem hiding this comment.
I am accepting this PR with following caveats:
- I am unable to test this change as this is Red Hat centric, therefore my checks were for code and linting.
- This role will never leave Experimental/Beta state unless code quality is improved to align it with rest of repository and project.
- Remaining Linting issues have to be fixed in future as this is design issue, not caused by this PR: #101
Note: Update of this role's readme will be done as part of #104
marcelmamula
changed the title
newkit
deleted the
feature_update_sap_hypervisor_node_preconfigure_rebased
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the code from the feature_update_sap_hypervisor_node_preconfigure branch but was rebased with the latest upstream dev branch.