Skip to content

Conversation

@marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Aug 6, 2025

Changes

We have initiated Readme overhaul across whole project this year and this PR aligns this repository with it.

  • Apply same format to role Readme documents with markdown markers for each section.

This is continuation of #104

@newkit Make sure to review it locally or in my branch as markdown cannot be reviewed well in github diff view.

  • Duplicated variables were removed and pointed towards var file instead.
  • We use role variable section in other repositories, but those are formatted differently and they would have to be added here afresh.

@marcelmamula marcelmamula requested a review from newkit August 6, 2025 13:36
@marcelmamula marcelmamula self-assigned this Aug 6, 2025
@marcelmamula marcelmamula added the documentation Improvements or additions to documentation label Aug 6, 2025
@marcelmamula
Copy link
Contributor Author

@newkit Let me know once you review this PR.

@newkit
Copy link
Member

newkit commented Aug 12, 2025

LGTM, I will address the content related changes in a new PR once this PR is merged.

Copy link
Member

@newkit newkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now as I will address the content related changes in a new PR once this PR is merged.

@marcelmamula marcelmamula merged commit c75afd2 into sap-linuxlab:dev Aug 12, 2025
3 checks passed
@marcelmamula marcelmamula deleted the readme3 branch September 23, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants