sap_hypervisor_node_preconfigure: Fix ansible-lint errors from issue 101 #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newkit
approved these changes
Sep 1, 2025
Member
newkit
left a comment
newkit
left a comment
There was a problem hiding this comment.
Tests in my automated deploy landscape have shown no issues with this PR for the kubvirt_vm part. Other code paths have not been tested. LGTM
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
# noqawere added in tasks which can be fixed in future, before this role is considered released out ofwip/beta. This ensures that newly added code gets validated with same criteria..ansible-lintfrom roleImportant
NOTE: All tests were done with
.ansible-lintcommented out on collection and role levels to find all errors. Only valid ones were uncommented.Tests
Changes were tested with ansible-lint executed on ansible-core
2.18and2.19.