Skip to content

Conversation

@marcelmamula
Copy link
Contributor

Changes

  • Update ansible-lint github actions to latest versions in pip3 installation sections to ensure better linting
          pip3 install \
            ansible-core~=2.18.0 \
            ansible~=11.0.0 \
            ansible-lint~=25.1.0 \
            ansible-compat~=25.1.0 \
            jmespath~=1.0.0
  • Restore skip_list items in ansible-lint configuration.

Why restore skip_list items?

There is difference between running commands from specific directories, which ignores configuration or hides errors.

  1. Running from repository as ansible-lint roles/sap_vm_provision produces no errors:
Passed: 0 failure(s), 0 warning(s) on 85 files. Last profile that met the validation criteria was 'production'.
  1. Running from roles/sap_vm_provision as ansible-lint produces errors when skip_list is commented out:
Failed: 769 failure(s), 0 warning(s) on 84 files. Last profile that met the validation criteria was 'min'.

Github actions are using second approach because of workdirs.

@marcelmamula marcelmamula self-assigned this Sep 2, 2025
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcelmamula marcelmamula merged commit 6891d6e into sap-linuxlab:dev Sep 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants