collection: Update Documentation #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
newkit
commented
Sep 18, 2025
newkit
commented
- Replaced relative links with absolute links.
- Mark sap_vm_provision(kubevirt) as beta.
- Mark sap_hypervisor_node_preconfigure(RHV) as deprecated.
- Added info about testing.
- removed unused dependency to community.okd.
- Replaced relative links with absolute links. - Mark sap_vm_provision(kubevirt) as beta. - Mark sap_hypervisor_node_preconfigure(RHV) as deprecated. - Added info about testing. - removed unused dependency to community.okd.
marcelmamula
requested changes
Sep 18, 2025
marcelmamula
requested changes
Sep 18, 2025
marcelmamula
requested changes
Sep 18, 2025
marcelmamula
requested changes
Sep 22, 2025
Member
Author
|
IMHO all requested changes are adressed. |
marcelmamula
approved these changes
Sep 23, 2025
Contributor
marcelmamula
left a comment
marcelmamula
left a comment
There was a problem hiding this comment.
LGTM, Updated PR title to align with format we use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.