Updated sap_hypervisor_node_preconfigure(redhat_ocpv)

[newkit]

Updated sap_hypervisor_node_preconfigure(redhat_ocpv)

- Added assert for kubeconfig - Unified storageclass to sapstorage for both trident and hpp and make configurable 
- trident: make parameters configurable in role 
- removed unused create-sap-bridge.yml, label-worker-invtsc.yml, sriov-enabled-unsupported-nics.sh 
- restructured tasks - added flags for finegranular tasks control, mainly for debugging 
- add vlan interface support - nmstate: wait for webhooks pods to be available 
- fix bridge and NAD name for additional bridges - added MCP wait to when installing hostpath provisioner 
- Storageclass names and default is configurable now - Wait and check for hco-webhook pod 
- hostpath provisioner: mkfs.xfs in pod, simplified systemd startup scripts

Deprecated vars

    sap_hypervisor_node_preconfigure_ocp_admin_username
    sap_hypervisor_node_preconfigure_ocp_admin_password
    sap_hypervisor_node_preconfigure_ocp_kubeconfig_path
    sap_hypervisor_node_preconfigure_ocp_ca_cert
    sap_hypervisor_node_preconfigure_ocp_extract_kubeconfig
    sap_hypervisor_node_preconfigure_ocp_endpoint
    sap_hypervisor_node_preconfigure_ocp_ca_cert

[marcelmamula]

@newkit Make sure to check ansible-lint and fix issues reported.

Error: Wrong indentation: expected 4 but found 5
Warning: Jinja2 spacing could be improved: {{ { 'cniVersion': '0.3.1', 'name': __sap_hypervisor_node_preconfigure_register_worker_network.name, 'type': 'cnv-bridge', 'bridge': __sap_hypervisor_node_preconfigure_register_worker_network.name, 'macspoofchk': true } | to_json }} -> {{ {'cniVersion': '0.3.1', 'name': __sap_hypervisor_node_preconfigure_register_worker_network.name, 'type': 'cnv-bridge', 'bridge': __sap_hypervisor_node_preconfigure_register_worker_network.name, 'macspoofchk': true} | to_json }}
You can skip specific rules or tags by adding them to your configuration file:
# .config/ansible-lint.yml
warn_list:  # or 'skip_list' to silence them completely
  - yaml[indentation]  # Violations reported by yamllint.

                Rule Violation Summary                
 count tag               profile rule associated tags 
     1 jinja[spacing]    basic   formatting (warning) 
     1 yaml[indentation] basic   formatting, yaml   

[newkit]

Linter issues are fixed and deprecated vars are added to initial commit message.

[newkit]

With the latest code all my CI tests are successful now.

[newkit]

@marcelmamula Does this PR look good to you now?

[marcelmamula]

I am accepting this PR with following caveats:

• I am unable to test this change as this is Red Hat centric, therefore my checks were for code and linting.
• This role will never leave Experimental/Beta state unless code quality is seriously improved to align it with rest of repository and project.
• Remaining Linting issues have to be fixed in future as this is design issue, not caused by this PR: #101

[geetikakay]

@newkit I have made some adjustments to the SSH-related vars in playbook and also we discussed about it here to match my test setup. When I run the playbook , I am seeing a lot of skipped tasks. I would like to review those with you before I give this patch a LGTM.

[geetikakay]

/hold

[marcelmamula]

@newkit @geetikakay Please reopen under correct direction to dev branch.
newkit wants to merge 16 commits into sap-linuxlab:main from newkit:feature_update_sap_hypervisor_node_preconfigure

[marcelmamula]

@geetikakay You need to create new PR