Skip to content

sap_software_download: Update for ansible-core 2.19 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

sap_software_download: Update for ansible-core 2.19 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a9236c
update sles 15 vars for 2.19
marcelmamula Aug 8, 2025
3197861
fix outdated ansible-lint action
marcelmamula Aug 8, 2025
5a22d9a
fix linting errors after action update
marcelmamula Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ansible-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Ansible Lint Action
uses: ansible-community/ansible-lint-action@v6.0.2
uses: ansible/ansible-lint@v6
6 changes: 4 additions & 2 deletions roles/sap_software_download/tasks/pre_steps/05_validate_relations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,10 @@

- name: Relationship Validation - Define list of files
ansible.builtin.set_fact:
__sap_software_download_files: "{{ sap_software_download_files if not sap_software_download_find_alternatives
else __sap_software_download_files_results_dryrun.results | selectattr('failed', 'false')| map(attribute='filename') | list | unique | d([])}}"
__sap_software_download_files:
"{{ sap_software_download_files
if not sap_software_download_find_alternatives
else __sap_software_download_files_results_dryrun.results | selectattr('failed', 'false') | map(attribute='filename') | list | unique | d([]) }}"


- name: Relationship Validation - SAP HANA - Multiple IMDB_SERVER files found
Expand Down
37 changes: 19 additions & 18 deletions roles/sap_software_download/vars/SLES_15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,22 @@ __sap_software_download_python_package: >-

# The list of required Python Modules in packages
# This is required in order to avoid externally-managed-environment error.
__sap_software_download_python_module_packages: >-
{%- if ansible_distribution_version.split('.')[1] | int < 5 -%}
[
"python3-wheel",
"python3-urllib3",
"python3-requests",
"python3-beautifulsoup4",
"python3-lxml"
]
{%- else -%}
[
"python311-wheel",
"python311-urllib3",
"python311-requests",
"python311-beautifulsoup4",
"python311-lxml"
]
{%- endif -%}
__sap_software_download_python_module_packages:
"{{ __sap_software_download_python_module_packages_3
if ansible_distribution_version.split('.')[1] | int < 5
else __sap_software_download_python_module_packages_311 }}"

# The lists of Python Modules for specific python version
__sap_software_download_python_module_packages_3:
- "python3-wheel"
- "python3-urllib3"
- "python3-requests"
- "python3-beautifulsoup4"
- "python3-lxml"

__sap_software_download_python_module_packages_311:
- "python311-wheel"
- "python311-urllib3"
- "python311-requests"
- "python311-beautifulsoup4"
- "python311-lxml"