Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .ansible-lint
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
---
# Collection wide lint-file
# DO NOT CHANGE
## Collection wide ansible-lint configuration file.
# Changes for ansible-lint v25.7.0+
# - Always executed from collection root using collection configuration.
# - .ansible-lint-ignore can be used to ignore files, not folders.
## Execution examples:
# ansible-lint
# ansible-lint roles/sap_swpm
# ansible-lint roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint

exclude_paths:
- .ansible/
- .cache/
- .github/
# - docs/
- changelogs/
- playbooks/
- tests/

enable_list:
- yaml

skip_list:
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/.ansible-lint

This file was deleted.

36 changes: 36 additions & 0 deletions .github/workflows/ansible-lint-sap_software_download.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Ansible Lint - sap_software_download

on:
push:
branches:
- main
- dev
paths:
- 'roles/sap_software_download/**'
pull_request:
branches:
- main
- dev
paths:
- 'roles/sap_software_download/**'

workflow_dispatch:

jobs:
ansible-lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5

# Use @v25 to automatically track the latest release from the year 2025.
# ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
# Avoid using @main, which can introduce breaking changes unexpectedly.
- uses: ansible/ansible-lint@v25
with:
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
# Role specific .ansible-lint can be added with argument '-c'.
args: roles/sap_software_download
# Use the shared requirements file from the collection root for dependency context.
requirements_file: ./requirements.yml
22 changes: 16 additions & 6 deletions .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
name: Ansible Lint
---
name: Ansible Lint - Collection

on: [push, pull_request]
on:
schedule:
# This is 03:05 UTC, which is 5:05 AM in Prague/CEST.
- cron: '5 3 * * 1'

workflow_dispatch:

jobs:
ansible-lint:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Ansible Lint Action
uses: ansible/ansible-lint@v6
# Use @v25 to automatically track the latest release from the year 2025.
# ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
# Avoid using @main, which can introduce breaking changes unexpectedly.
- uses: ansible/ansible-lint@v25
with:
# Use the shared requirements file from the collection root for dependency context.
requirements_file: ./requirements.yml
84 changes: 84 additions & 0 deletions .github/workflows/ansible-test-sanity.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
---
# Always check ansible-core support matrix before configuring units matrix.
# https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix

name: Ansible Test - Sanity

on:
schedule:
# This is 01:05 UTC, which is 3:05 AM in Prague/CEST
- cron: '5 3 * * 1'

pull_request:
branches:
- main
- dev

workflow_dispatch:

jobs:
sanity-supported:
runs-on: ubuntu-latest
name: Sanity (Supported Ⓐ${{ matrix.ansible }})
strategy:
fail-fast: false # Disabled so we can see all failed combinations.
# Define a build matrix to test compatibility across multiple Ansible versions.
# Each version listed below will spawn a separate job that runs in parallel.
matrix:
ansible:
- 'stable-2.18' # Python 3.11 - 3.13
- 'stable-2.19' # Python 3.11 - 3.13
- 'devel' # Test against the upcoming development version.

steps:
- uses: actions/checkout@v5

- name: ansible-test - sanity
uses: ansible-community/ansible-test-gh-action@release/v1
with:
ansible-core-version: ${{ matrix.ansible }}
testing-type: sanity

sanity-eol:
runs-on: ubuntu-latest
# This job only runs if the supported tests pass
needs: sanity-supported
name: Sanity (EOL Ⓐ${{ matrix.ansible }}+py${{ matrix.python }})
continue-on-error: true # This entire job is allowed to fail
strategy:
fail-fast: false # Disabled so we can see all failed combinations.
# Define a build matrix to test compatibility across multiple Ansible versions.
# Each version listed below will spawn a separate job that runs in parallel.
matrix:
ansible:
- 'stable-2.14' # Python 3.9 - 3.11
- 'stable-2.15' # Python 3.9 - 3.11
- 'stable-2.16' # Python 3.10 - 3.12
- 'stable-2.17' # Python 3.10 - 3.12
python:
- '3.9'
- '3.10'
- '3.11'
- '3.12'
exclude:
# Exclusions for incompatible Python versions.
- ansible: 'stable-2.14'
python: '3.12'

- ansible: 'stable-2.15'
python: '3.12'

- ansible: 'stable-2.16'
python: '3.9'

- ansible: 'stable-2.17'
python: '3.9'
steps:
- uses: actions/checkout@v5

- name: ansible-test - sanity
uses: ansible-community/ansible-test-gh-action@release/v1
with:
ansible-core-version: ${{ matrix.ansible }}
target-python-version: ${{ matrix.python }}
testing-type: sanity
13 changes: 13 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@ community.sap\_launchpad Release Notes

.. contents:: Topics

v1.3.1
======

Release Summary
---------------

Various bug fixes fixing issues identified by new workflows for sanity tests.

Bugfixes
--------
- collection: Add ansible-test sanity workflow and fix sanity errors (https://github.com/sap-linuxlab/community.sap_launchpad/pull/55)


v1.3.0
======

Expand Down
77 changes: 77 additions & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
# Contributors to community.sap_launchpad

Thank you to all contributors who have helped make this project possible!

We welcome contributions! Please see our [contributing guidelines](https://sap-linuxlab.github.io/initiative_contributions/) to get started.

## Maintainers

The following people are the maintainers of this collection:

### SUSE

- [Marcel Mamula](https://github.com/marcelmamula)


For specific role maintainers, see the `README.md` file in the corresponding role's directory.

## All Contributors

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Marcel Mamula](https://github.com/marcelmamula) | 45 | 11303 | 2025-11-11 |
| [Sean Freeman](https://github.com/sean-freeman) | 35 | 2915 | 2025-03-31 |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 12 | 885 | 2023-11-12 |
| [Markus Koch](https://github.com/rhmk) | 1 | 32 | 2022-10-21 |
| 朱聖黎 Zhu Sheng Li | 1 | 209 | 2022-04-11 |

## Contributions by Role

### Role: sap_software_download

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Marcel Mamula](https://github.com/marcelmamula) | 15 | 2408 | 2025-09-10 |

## Contributions by Module

### Module: license_keys.py

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 9 | 351 | 2023-11-12 |
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 181 | 2025-10-08 |

### Module: maintenance_planner_stack_xml_download.py

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Marcel Mamula](https://github.com/marcelmamula) | 5 | 126 | 2025-10-08 |
| [Sean Freeman](https://github.com/sean-freeman) | 3 | 156 | 2024-11-09 |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |

### Module: systems_info.py

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 5 | 121 | 2023-11-12 |
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 72 | 2025-10-08 |

### Module: maintenance_planner_files.py

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Marcel Mamula](https://github.com/marcelmamula) | 4 | 134 | 2025-10-08 |
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 161 | 2024-11-09 |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |

### Module: software_center_download.py

| Name | Commits | Lines Changed | Last Commit |
| ---- | ------- | ------------- | ----------- |
| [Marcel Mamula](https://github.com/marcelmamula) | 11 | 627 | 2025-10-08 |
| [Sean Freeman](https://github.com/sean-freeman) | 6 | 189 | 2024-11-09 |
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |
| [Markus Koch](https://github.com/rhmk) | 1 | 11 | 2022-10-21 |
| 朱聖黎 Zhu Sheng Li | 1 | 44 | 2022-04-11 |

5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ This Ansible Collection was tested across different Operating Systems and SAP pr


## Contributing
You can find more information about ways you can contribute at [sap-linuxlab website](https://sap-linuxlab.github.io/initiative_contributions/).

We welcome contributions to this collection. For a list of all contributors and information on how you can get involved, please see our [CONTRIBUTORS document](./CONTRIBUTORS.md).


## Support
Expand All @@ -120,7 +121,7 @@ When an SAP User ID (e.g. S-User) is enabled with and part of an SAP Universal I
- the SAP User ID
- the password for login with the SAP Universal ID

In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID Account Password in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.
In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID `Account Password` in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.

For further information regarding connection errors, please see the FAQ section [Errors with prefix 'SAP SSO authentication failed - '](./docs/FAQ.md#errors-with-prefix-sap-sso-authentication-failed---).

Expand Down
7 changes: 7 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
ancestor: null
releases:
1.3.1:
release_date: '2025-11-11'
changes:
release_summary: Various bug fixes fixing issues identified by new workflows for sanity tests
bugfixes:
- collection - Add ansible-test sanity workflow and fix sanity errors (https://github.com/sap-linuxlab/community.sap_launchpad/pull/55)

1.3.0:
release_date: '2025-09-23'
changes:
Expand Down
13 changes: 0 additions & 13 deletions docs/CONTRIBUTORS.md

This file was deleted.

2 changes: 1 addition & 1 deletion docs/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The error HTTP 401 refers to either:
- Unauthorized, the SAP User ID being used belongs to an SAP Company Number (SCN) with one or more Installation Number/s which do not have license agreements for these files
- Unauthorized, the SAP User ID being used does not have SAP Download authorizations
- Unauthorized, the SAP User ID is part of an SAP Universal ID and must use the password of the SAP Universal ID
- In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID Account Password in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.
- In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID `Account Password` in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.

This is documented under [Execution - Credentials](https://github.com/sap-linuxlab/community.sap_launchpad#requirements-dependencies-and-testing).

Expand Down
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace: community
name: sap_launchpad

# The version of the collection. Must be compatible with semantic versioning
version: 1.3.0
version: 1.3.1

# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
readme: README.md
Expand Down
Loading