Skip to content

Feedbk fr github #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Feedbk fr github #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff3feb1
Changed to "Service Instance"
julieplummer20 Feb 28, 2025
fc27137
Feedbk fr github
julieplummer20 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tutorials/abap-env-rfc/abap-env-rfc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ For readability and reuse, you will create these in an interface.

2. Enter the following and choose **Next**.

- Name: **`IF_TYPES_FOR_SYSTEM_INFO`**
- Name: **`ZIF_TYPES_FOR_SYSTEM_INFO`**
- Description: **`Types for RFC_GET_SYSTEM_INFO`**

3. Choose the transport request, then choose **Finish**.
Expand Down Expand Up @@ -348,7 +348,7 @@ In the class implementation, in the method **`if_oo_adt_classrun~main`**, add th

DATA(lv_destination) = lo_destination->get_destination_name( ).

DATA lv_result type IF_TYPES_FOR_SYSTEM_INFO=>rfcsi.
DATA lv_result type ZIF_TYPES_FOR_SYSTEM_INFO=>rfcsi.
DATA msg TYPE c LENGTH 255.

```
Expand Down Expand Up @@ -451,13 +451,13 @@ CLASS ZCL_SYSTEM_INFO_RFC_### IMPLEMENTATION.

comm_scenario = 'Z_OUTBOUND_RFC_###_CSCEN' " Communication scenario
service_id = 'Z_OUTBOUND_RFC_###_SRFC' " Outbound service
comm_system_id = 'Z_OUTBOUND_RFC_CSYS' " Communication system
comm_system_id = 'Z_OUTBOUND_RFC_CSYS_###' " Communication system

).

DATA(lv_destination) = lo_destination->get_destination_name( ).

DATA lv_result TYPE if_types_for_system_info=>RFCSI.
DATA lv_result TYPE ZIF_TYPES_FOR_SYSTEM_INFO=>RFCSI.
DATA msg TYPE c LENGTH 255.

CALL FUNCTION 'RFC_GET_SYSTEM_INFO'
Expand Down
12 changes: 8 additions & 4 deletions ...ls/abap-environment-create-http-service/abap-environment-create-http-service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ author_profile: https://github.com/julieplummer20
- How to return system data using a (whitelisted) ABAP utility class
- How to expose the service for external consumption, by defining the necessary inbound communication artifacts

Important: This tutorial is not suitable for SAP S/4HANA Cloud, private edition. If you would like to enable HTTP consumption from S/4HANA Cloud, private edition, see:

- [Developing External Service Consumption - Outbound Communication](https://help.sap.com/docs/ABAP_PLATFORM_NEW/b5670aaaa2364a29935f40b16499972d/f871712b816943b0ab5e04b60799e518.html)
- [Enable HTTP Communication in Your ABAP Code](https://help.sap.com/docs/ABAP_PLATFORM_NEW/b5670aaaa2364a29935f40b16499972d/cef1ada754154d11b5701ab60e6ab412.html?version=202310.002)


Throughout this tutorial, replace `XXX` or `000` with your initials or group number.

---
Expand Down Expand Up @@ -109,13 +115,12 @@ In the ABAP environment, you can only use whitelisted APIs. Therefore, for examp

```ABAP

DATA(user_formatted_name) = cl_abap_context_info=>get_user_formatted_name( ).
DATA(system_date) = cl_abap_context_info=>get_system_date( ).

ui_html = |<html> \n| &&
|<body> \n| &&
|<title>General Information</title> \n| &&
|<p style="color:DodgerBlue;"> Hello there, { user_formatted_name } </p> \n | &&
|<p style="color:DodgerBlue;"> Hello there </p> \n | &&
|<p> Today, the date is: { system_date }| &&
|<p> | &&
|</body> \n| &&
Expand Down Expand Up @@ -174,13 +179,12 @@ CLASS Z_GET_DATE_HTTP_000 IMPLEMENTATION.

METHOD get_html.

DATA(user_formatted_name) = cl_abap_context_info=>get_user_formatted_name( ).
DATA(system_date) = cl_abap_context_info=>get_system_date( ).

ui_html = |<html> \n| &&
|<body> \n| &&
|<title>General Information</title> \n| &&
|<p style="color:DodgerBlue;"> Hello there, { user_formatted_name } </p> \n | &&
|<p style="color:DodgerBlue;"> Hello there.</p> \n | &&
|<p> Today, the date is: { system_date }| &&
|<p> | &&
|</body> \n| &&
Expand Down
Binary file modified tutorials/abap-environment-trial-onboarding/step2a-go-to-instance.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.