openstack-seeder: support selecting or ignoring multiple namespaces #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is backwards-compatible with existing invocations.
majewsky
commented
May 28, 2024
|
|
||
| "github.com/getsentry/raven-go" | ||
| "github.com/golang/glog" | ||
| "k8s.io/client-go/tools/clientcmd" |
Contributor
Author
There was a problem hiding this comment.
FYI, my auto-formatter reshuffled the imports here.
|
|
||
| if err = cmd.Start(); err != nil { | ||
| glog.Errorf("ERROR: could not spawn %s: ", seeder_name, err) | ||
| glog.Errorf("ERROR: could not spawn %s: %v", seeder_name, err) |
Contributor
Author
There was a problem hiding this comment.
FYI, my linter complained about this clearly wrong statement, so I fixed this while having the file open.
rajivmucheli
approved these changes
May 29, 2024
stefanhipfel
approved these changes
May 29, 2024
majewsky
added a commit
to sapcc/helm-charts
that referenced
this pull request
May 29, 2024
This requires the patch from <sapcc/kubernetes-operators#105> to be applied.
stefanhipfel
pushed a commit
to sapcc/helm-charts
that referenced
this pull request
Nov 26, 2024
…6597) This requires the patch from <sapcc/kubernetes-operators#105> to be applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is backwards-compatible with existing invocations.
My intention here is that I have been asked to deploy Limes for the
globaldeployment. I will not put my deployment intomonsoon3globalbecause Limes expects to be deployed into its own namespace, so I want to reconfigure the global seeder to also look at namespacelimes-global.