Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ANSI functionality #165

Closed
wants to merge 2 commits into from
Closed

Conversation

abdullah-if
Copy link

Added ANSI functionality, present for long time in Windows version. Obsolete and non-standard yet may cover corner cases. Converter from was found here.

@abdullah-if
Copy link
Author

Using ANSI for Bangla writing is non-standard and should not be supported. It is the users who should change rather than Avro. I take back my PR.

@sarim
Copy link
Owner

sarim commented Feb 24, 2021

Thank you very much for your contribution. I appreciate you contributing to the repo :) Unfortunately this PR isn't suitable for the project right now. Current (javascript) version is in feature freeze. New features would be in v2 (golang version). Also this PR includes a library that is clearly a converter for bijoy, which is a proprietary layout. For obvious reasons I can't accept that code into ibus-avro.

@archisman-panigrahi
Copy link
Contributor

which is a proprietary layout

@sarim Is it that even the layout is copyrighted and cannot be included in any other software?

@oritromax
Copy link

@apandada1 Yes :)

@abdullah-if
Copy link
Author

Quick question, how Avro in Windows implement ANSI ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants