Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@amcgregor
Copy link
Contributor

Fixes #41.

@asottile
Copy link
Member

Looks like your change fails flake8. Could you fix that and add a quick test?

Other than that, :shipit:

@amcgregor
Copy link
Contributor Author

Yup, noticed the flake8 failure… wow those Travis tests take a long time to complete. Updating now.

@amcgregor
Copy link
Contributor Author

Should be good to go.

asottile added a commit that referenced this pull request Nov 24, 2015
Support for string compilation using indented (SASS) string syntax.
@asottile asottile merged commit e3d3380 into sass:python Nov 24, 2015
@asottile
Copy link
Member

Thanks for the PR!

@amcgregor
Copy link
Contributor Author

It never hurts to help. I may tackle the @import callback thing (#81) later, as it's needed at work. Do you have a release schedule for pypi published releases?

@amcgregor amcgregor deleted the feature/41-indented-strings branch November 24, 2015 20:00
@asottile
Copy link
Member

I usually release whenever someone asks or when I need a new release. Would you like me to cut a new version?

@amcgregor
Copy link
Contributor Author

@asottile Ah, might wait until I've pushed the @import callback code, but after that for sure. That's a significant feature to add.

@asottile
Copy link
Member

Sounds good to me, looking forward to reviewing :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants