Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@asottile
Copy link
Member

@asottile asottile commented Feb 5, 2016

Resolves #120

@asottile
Copy link
Member Author

asottile commented Feb 5, 2016

\o/ passed travis and appveyor -> ready for review

@dahlia
Copy link
Member

dahlia commented Feb 6, 2016

It would be better if CONTRIBUTING.rst is also updated.

@asottile
Copy link
Member Author

asottile commented Feb 6, 2016

CONTRIBUTING.rst doesn't seem to mention setup.py test, but that does remind me that tox needs updating

@asottile
Copy link
Member Author

asottile commented Feb 6, 2016

updated tox.ini

- pip install -rrequirements-dev.txt coveralls
script:
- coverage run --source sass,sassc,sassutils setup.py test
- coverage run --source sass,sassc,sassutils -m pytest sasstests.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using pytest-cov?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could, but yagni?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary! 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used it before, maybe we could add it in a followup.

asottile added a commit that referenced this pull request Feb 19, 2016
Use pytest instead of setup.py test
@asottile asottile merged commit f6e4378 into sass:python Feb 19, 2016
@asottile asottile deleted the use_pytest branch February 19, 2016 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants