fix: update meta tags in layout and mod page #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layout page now uses dynamic handling of <meta> tags and supplies default metadata. refs satisfactorymodding#177, satisfactorymodding#174, satisfactorymodding#172
|
@QuantumPickleJar is attempting to deploy a commit to the satisfactorymodding Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
budak7273
requested changes
Sep 22, 2024
Member
budak7273
left a comment
budak7273
left a comment
There was a problem hiding this comment.
Tested locally, and it still seems to be adding new sets of head elements every time you change pages.
- Visit http://localhost:3000/ and open devtools. There are already multiple Title elements.
- Click on the Tools page. The first Title has updated but there is another set.
- Navigate to any other page (ex. Guides). Displayed tab title remains
Tools - SMRand another set is generated
Member
|
Closing due to inactivity, feel free to reopen if you'd like to work on this again |
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Completed
in Mod Repository (SMR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+layout.sveltepage now uses dynamic handling of tags AND supplies default metadata.refs #177, #174, #172
TESTING NEEDED!
Aiming to fix #90