4️⃣ CHAPTER_04 repository #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawaca96
commented
Jan 22, 2023
Comment on lines
-18
to
-22
| - repo: https://github.com/pycqa/isort | ||
| rev: 5.10.1 | ||
| hooks: | ||
| - id: isort | ||
| name: isort (python) |
Comment on lines
+21
to
+23
| @dataclass(unsafe_hash=True, kw_only=True) # TODO: kw_only를 언제 써야 할까? | ||
| class OrderLine: | ||
| id: UUID |
There was a problem hiding this comment.
increment Integer를 id로 사용할 경우 DB에서 관리하는 id값을 application에서 미리 알 수 없기 때문에 id를 UUID로 변경하였습니다.
추가로 id를 미리 생성할 수 있다면 ref필드가 필요 없기 때문에 제거 했습니다. 이 부분은 제 해석이긴 한데, 책에서 DB에서 생성해주는 id값을 미리 알 수 없어서 id와 같은 필드로 ref를 사용하고 있었던 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.