Skip to content

Conversation

@sawaca96
Copy link
Owner

@sawaca96 sawaca96 commented Feb 9, 2023

No description provided.

Copy link
Owner Author

@sawaca96 sawaca96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이벤트 구현부터 뭔가 복잡해진다.

이벤트버스는 라이브러리를 사용해서 구현하는 게 더 깔끔할 수도?

async def _get_by_batch_id(self, batch_id: UUID) -> models.Product:
result = await self._session.execute(
sa.select(models.Product)
.where(models.Product.batches.any(models.Batch.id == batch_id)) # type: ignore
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정적분석시에는 batches가 orm이 아니기 때문에 타입에러 발생

@sawaca96 sawaca96 merged commit 781d4eb into main Feb 9, 2023
@sawaca96 sawaca96 deleted the ch09 branch February 9, 2023 13:42
sawaca96 added a commit that referenced this pull request Feb 9, 2023
sawaca96 added a commit that referenced this pull request Feb 9, 2023
@sawaca96 sawaca96 changed the title 8️⃣ CHAPTER_09 messagebus 9️⃣ CHAPTER_09 messagebus Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant