Centralize shared in the library. #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update version to v0.1.12 and refactor attributes * Add docstrings to methods in shared.py Added docstrings for methods in shared.py to improve code documentation and clarity. * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update SCR/valetudo_map_parser/config/shared.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… shared updated locally Signed-off-by: Sandro Cantarella <sandro@a3a68459-3659-4d50-ae96-08f848c5a8b3.fritz.box>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes shared data management in the Valetudo map parser library by modifying the async_get_image method to return a tuple containing both PIL image and data dictionary, making this a breaking change. The PR also updates the workflow to use trusted publishing for PyPI releases.
- Modified async_get_image to return tuple (PIL image, data dictionary) instead of just PIL image
- Added centralized shared data update mechanism through _async_update_shared_data method
- Updated GitHub workflow to use trusted publishing for PyPI releases
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump from 0.1.10rc5 to 0.1.10rc6 |
| SCR/valetudo_map_parser/hypfer_handler.py | Modified get_calibration_data to accept rotation_angle parameter |
| SCR/valetudo_map_parser/config/utils.py | Updated async_get_image return type and added shared data centralization |
| SCR/valetudo_map_parser/config/types.py | Added new TypedDict classes for destinations structure |
| SCR/valetudo_map_parser/config/shared.py | Code cleanup and added to_dict method for data serialization |
| .github/workflows/release.yaml | Updated to use trusted publishing instead of manual token configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sandro Cantarella <sandro@a3a68459-3659-4d50-ae96-08f848c5a8b3.fritz.box>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already made the shared to dictionary possible and this changes we update the shared data locally at current we return a pil and data dictionary so this is a braking change. Workflow release changed.