Added script to build deb file. #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your PR. Unfortunately, I don't think I want such a script to make it into this repo. My main issue is that if we include a script for Debian, then there is no reason not to include scripts for every other main package manager, and that also includes Windows and Mac OS stuff. And there's no way we can test all that stuff. So I'd rather keep this repo simple and generate .zip and .tgz only, as we've always done. I would consider a PR integrating with sbt-native-packager, producing packages for at least Linux/Mac OS/Windows, and tested in CI. Thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was no script to install the files into the system so I wrote up a script which I thought would belong in the repo.