Upgrade to scalajs 1.7 #35
Conversation
clutroth
force-pushed
the
scalajs-1.7.0
branch
2 times, most recently
from
587e085 to
a49232b
Compare
.github/workflows/ci.yml
Outdated
| scalaversion: ["2.11.12", "2.12.10", "2.13.1"] | ||
| scalajsversion: ["1.5.0"] | ||
| scalaversion: ["2.11.12", "2.12.15", "2.13.6"] | ||
| scalajsversion: ["1.7.0", "1.7.1"] |
There was a problem hiding this comment.
I do not quite understand how this is supposed to work: Won't we publish the CLI for a single Scala.js version only anyways? If so, what's the point of testing with an older one?
There was a problem hiding this comment.
You're right. It's pointless.
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version=1.2.8 | |||
| sbt.version=1.5.5 | |||
There was a problem hiding this comment.
Put the sbt version upgrade into a separate commit to reduce noise?
|
@clutroth thank you for your contributions to the CLI. I realize we have not even tagged a release after your last PR. Apologies for that. @sjrd, I suggest we simply start releasing on its own versioning scheme? maybe with minor version bumps if we upgrade the minor Scala.js version? Definitely not the cleanest option, but better than not releasing at all :-/ WDYT? |
|
Yes, probably that's what we should do. Ideally I think we should explore something using |
clutroth
force-pushed
the
scalajs-1.7.0
branch
from
a49232b to
c9a6f01
Compare
|
Glad to help :) I'd appreciate release. |
3 participants
No description provided.