Upgrade sbt #36
Merged
Upgrade sbt #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scalajs compiler is not released for scala 2.12.14;1.5.0, etc. I'll wait for scalajscli for scalajs1.7 |
|
There's no need to upgrade the Scala versions at the same time as the sbt version. In fact, those things should be separated. |
sjrd
requested changes
Nov 2, 2021
build.sbt
Outdated
| mainClass in assembly := None, // don't want an executable JAR | ||
| assemblyOption in assembly ~= { _.copy(includeScala = false) }, | ||
| assemblyJarName in assembly := | ||
| assembly / mainClass := None, // don't want an executable JAR |
There was a problem hiding this comment.
There's always one space too many on the right of /. For example here:
Suggested change
| assembly / mainClass := None, // don't want an executable JAR | |
| assembly / mainClass := None, // don't want an executable JAR |
Could you amend that?
Otherwise, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.