Fix WebGL signatures. #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with the type signatures of some WebGL calls:
polygonOffsetwas(Int, Int) => Unit, rather than(Double, Double) => UnitlineWidthwas(Int) => Unit, rather than(Double) => UnittexParameterfwas(Int, Int, Int) => Unit, rather than(Int, Int, Double) => UnitAlso cleaned up some incorrect parameter documentation, and further clarified internalformat/format.
I also tried (uncommitted) to prevent some scaladoc warnings in this file of the form "Could not find any member to link for "Float32Array", but for some reason (possibly because it's external to scala-js-dom?) even fully qualified names still issue a warning. If anyone has any idea how to handle this correctly, I'll combine that into this PR, too, since this file got a little shouty since the introduction of
scalajs.js.typedarray.