Skip to content

Conversation

@mseddon
Copy link
Contributor

@mseddon mseddon commented Jun 25, 2015

Fixes a few issues with the type signatures of some WebGL calls:

polygonOffset was (Int, Int) => Unit, rather than (Double, Double) => Unit
lineWidth was (Int) => Unit, rather than (Double) => Unit
texParameterf was (Int, Int, Int) => Unit, rather than (Int, Int, Double) => Unit

Also cleaned up some incorrect parameter documentation, and further clarified internalformat/format.

I also tried (uncommitted) to prevent some scaladoc warnings in this file of the form "Could not find any member to link for "Float32Array", but for some reason (possibly because it's external to scala-js-dom?) even fully qualified names still issue a warning. If anyone has any idea how to handle this correctly, I'll combine that into this PR, too, since this file got a little shouty since the introduction of scalajs.js.typedarray.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be renamed to format instead of removing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in general, there seems to be many removals that should have been renamings instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I got a little carried away there...

@sjrd
Copy link
Member

sjrd commented Jun 25, 2015

OK for the actual signature changes. These should be in a different commit than the documentation fixes, since they have nothing to do with each other.
You can easily recreate your commits first with git reset HEAD^ (removes the top commit but keeps its changes, in the working copy) then git add -p (allows you to stage parts of the working copy to create a commit).

@mseddon mseddon force-pushed the webgl-fix-signatures branch from 98c2234 to 3c832e0 Compare June 25, 2015 13:36
@sjrd
Copy link
Member

sjrd commented Jun 25, 2015

LGTM

@mseddon
Copy link
Contributor Author

mseddon commented Jun 25, 2015

Any ideas on the scaladoc warnings, or should we just ignore them for now?

@sjrd
Copy link
Member

sjrd commented Jun 25, 2015

Ignore them for now. I think there is something that needs to be done about linking different ScalaDocs with each other, but I never really understood how that worked. Anyway it's worth a separate PR.

@mseddon
Copy link
Contributor Author

mseddon commented Jun 25, 2015

Alrighty. Ta!

sjrd added a commit that referenced this pull request Jun 25, 2015
@sjrd sjrd merged commit 05d87d8 into scala-js:master Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants