-
Couldn't load subscription status.
- Fork 159
WebRTC Additions #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC Additions #203
Conversation
|
Ah, yes, https://github.com/coreyauger/scala-js-dom/blob/master/src/main/scala/org/scalajs/dom/package.scala#L106 remove this reference to https://github.com/coreyauger/scala-js-dom/blob/master/src/main/scala/org/scalajs/dom/raw/Audio.scala#L12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three URLS? :)
|
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trackId: String - best to use the name in the spec and fix the spacing around the :
|
That's all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for "READONLY". We know it's read-only thanks to our type system (it's a val or def)
|
That's all. |
9c1e5f2 to
bdb432c
Compare
|
OK could you please squash the two commits into one? |
35ea799 to
1262bce
Compare
|
Done. Thanks :) |
|
LGTM |
|
👍 thanks for all your effort @coreyauger, much appreciated! |
No description provided.