FF ONLY Version 1.0.0-RC3. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a quickly released fix to the fact that 1.0.0-RC2 does not support jsdom >= 12 at all.
Releasing such a 1.0.0-RC3, that is still built against Scala.js 1.0.0-RC2, is not fundamentally problematic (the version numbers don't have to match), but it will introduce a shift in the version numbers in case we publish more RCs for Scala.js. Given that further RCs are pretty unlikely at this point, I believe this is the best way to unblock codebases that need jsdom to be tested and published for Scala.js 1.0.0-RC2.