Commit acfe949
committed
Add ability to pass
I'm running tests in a Docker container
(https://hub.docker.com/r/gshakhn/sbt-firefox-chromium/).
Chrome and Docker don't play well together unless you pass
`--no-sandbox` to Chrome (elgalu/docker-selenium#9)
This change lets me set pass in `ChromeOptions` with the custom argument
to Chrome.
This is a breaking change since `Chrome` is now a class instead of an
object. Update readme to reflect that.
Other than the above, this should be backwards compatible.
The overloaded constructor of `ChromeDriver` just calls
`options.toCapabilities`, which has the old `DesiredCapabilities.chrome`
code.ChromeOptions to the ChromeDriver.1 parent 18b416b commit acfe949
File tree
2 files changed
+5
-5
lines changed- seleniumJSEnv/src/main/scala/org/scalajs/jsenv/selenium
2 files changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
0 commit comments