-
Notifications
You must be signed in to change notification settings - Fork 5
Add Scala 3 build #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For Scala 3 support, I would prefer a single PR with multiple commits: one for each kind of required change in the code, and finally one that adds building with Scala 3. Otherwise we can't really test whether the changes actually work. |
ea849d9
to
5c9ea6b
Compare
final
d324cd0
to
4802be5
Compare
} | ||
|
||
@tailrec | ||
private def waitOnMessageLoop(deadline: Deadline): String = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
final object RunConfig { | ||
object RunConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[error] 122 |final object RunConfig {
[error] |^^^^^
[error] |Modifier final is redundant for this definition
4802be5
to
b614fb0
Compare
The code changes look good. I only have nits on the commit messages:
|
``` [error] 122 |final object RunConfig { [error] |^^^^^ [error] |Modifier final is redundant for this definition ```
No description provided.