Implemented local search with lunr.js #209
Conversation
| <a class="grey-text text-lighten-3" href="https://groups.google.com/forum/?fromgroups#!forum/scala-js">Mailing list</a> | ||
| <a class="grey-text text-lighten-3" href="https://groups.google.com/forum/?fromgroups#!forum/scala-js">Mailing list</a><br/> | ||
| <a class="grey-text text-lighten-3" href="http://twitter.com/scala_js">Twitter <i aria-hidden="true" class="fa fa-twitter"></i></a><br/> | ||
| <a href="http://github.com/scala-js/scala-js">GitHub <i aria-hidden="true" class="fa fa-github"></i></a> |
There was a problem hiding this comment.
This looks like it should be in a separate PR.
There was a problem hiding this comment.
This is here because Twitter and Github links were removed from the top menu to make space for the search icon.
|
When I load the page, the |
|
UI-wise, the interface is confusing. When I type in something, I have to switch to the mouse to go and click on a link. I would like to use up/down arrows to select things + Enter to go. Enter could default to the first item. Also, the search "button" at the right of the input box appears as a link but does nothing. It should be removed if it doesn't do anything. |
|
That's all, I think. |
|
The search data download is deferred after the page is shown, so it doesn't hinder usage. It's also cached and gzipped, so the penalty is quite low. If it were downloaded only when the search button is clicked, it would be too late from UX point of view. After gzip it's <100kB in size. |
There's still the time to download it while the user types in something.
I guess that's acceptable, but it still feels like a big hit for all the mobile users who won't ever use the search box, if they hit it on Data usage. |
|
Maybe I'm too paranoid, here. |
|
The search button is indeed superfluous, but you can navigate with Tab+Enter. I'll make an update for this. Arrow key navigation would be nice, but probably requires a bit more work, so can do that as a separate update later. On mobile the issue is latency, not bandwidth, so downloading search data JIT would not work that well. Besides, comparing to the old scala-js.org site, I think the overall download size and request count is still way less :) |
|
OK |
|
That's all. |
JS loading is deferred until after page render. Note: .json compression must be enabled before merging this due to the large size of the search index.md
|
LGTM |
Implemented local search with lunr.js
2 participants
JS loading is deferred until after page render.
Note: .json compression must be enabled before merging this due to the large size of the search index.json