Skip to content

Conversation

@rockjam
Copy link
Contributor

@rockjam rockjam commented Jan 30, 2016

Not ideal, but at least visible

@rockjam
Copy link
Contributor Author

rockjam commented Jan 30, 2016

Looks this way now.

image

@sjrd
Copy link
Member

sjrd commented Jan 31, 2016

Hum ... This disturbs the visual left/right balance of the title.

I suggest trying either of:

  • Putting the version number on a separate line, below "Scala.js" (I would also suggest a bit more opaque, like 0.7 or 0.8)
  • Using the same size and opacity as "Scala.js" (so basically, not changing it)

@rockjam
Copy link
Contributor Author

rockjam commented Jan 31, 2016

Here are variations:

  • Same font, same line, no opacity
    image
  • Same font, same line, opacity 70% or so
    image
  • Smaller font, opacity 70%, separate line
    image

Which one is more suitable on your opinion?

@sjrd
Copy link
Member

sjrd commented Jan 31, 2016

My favorite is the last one. IMO it's the one with the best balance.

@rockjam
Copy link
Contributor Author

rockjam commented Jan 31, 2016

Same for me

@rockjam
Copy link
Contributor Author

rockjam commented Jan 31, 2016

Just updated pull request

index.html Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure not to introduce tabs. We use spaces only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for that, will fix

@sjrd
Copy link
Member

sjrd commented Jan 31, 2016

Also could you use this commit message format, which is what we use:

Fix #196: Add the Scala.js version on the front page.

That's all.

@rockjam rockjam changed the title Scala.js version on front page. fixes #196 Fix #196: Add the Scala.js version on the front page. Jan 31, 2016
@rockjam
Copy link
Contributor Author

rockjam commented Jan 31, 2016

All right, no tabs, and proper commit message - done.

@sjrd
Copy link
Member

sjrd commented Jan 31, 2016

LGTM Thanks!

sjrd added a commit that referenced this pull request Jan 31, 2016
Fix #196: Add the Scala.js version on the front page.
@sjrd sjrd merged commit a95a1b5 into scala-js:master Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants